Skip to content

Commit

Permalink
[Feature store] Support deployment of an empty graph ingestion service (
Browse files Browse the repository at this point in the history
  • Loading branch information
Gal Topper authored May 15, 2021
1 parent 5901bf0 commit a8a438a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion mlrun/datastore/targets.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def _get_store(self):
return store

def _get_column_list(self, features, timestamp_key, key_columns):
column_list = None
column_list = []
if self.columns:
return self.columns
elif features:
Expand Down
2 changes: 1 addition & 1 deletion mlrun/runtimes/serving.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ def _get_runtime_env(self):
"function_uri": self._function_uri(),
"version": "v2",
"parameters": self.spec.parameters,
"graph": self.spec.graph.to_dict(),
"graph": self.spec.graph.to_dict() if self.spec.graph else {},
"load_mode": self.spec.load_mode,
"functions": function_name_uri_map,
"graph_initializer": self.spec.graph_initializer,
Expand Down
5 changes: 0 additions & 5 deletions mlrun/serving/states.py
Original file line number Diff line number Diff line change
Expand Up @@ -774,11 +774,6 @@ def has_loop(state, previous):
if self.on_error and self.on_error in start_states:
start_states.remove(self.on_error)

if (
not start_states
): # for safety, not sure if its possible to get here (since its a loop)
raise GraphError("there are no starting states (ones without .after)")

if (
len(responders) > 1
): # should not have multiple steps which respond to request
Expand Down

0 comments on commit a8a438a

Please sign in to comment.