285 file sharing #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know how to solve the authorization error I get in the checkings. |
|
Looks like there's some recently added nonsense regarding parsing of the deploy key (public key host label "does not match GitHub URL pattern. Not treating it as a GitHub deploy key") |
|
Looks like we have to modify the public key so that the comment references the repository being pulled from so we'll need to get the goaliejs guys to add our modified public key to their accepted deploy keys. No idea why this suddenly stopped working recently or why the comment (which traditionally tells you which machine generated the key pair) is being abused in this fashion. |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request the modifications to the broker and the API needed to use the file sharing functionality have been implemented, together with example stories.
A detailed explanation of the workflow is reported here.