Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to user selected camera matching #1556

Merged
merged 98 commits into from
Jan 1, 2025

Conversation

oh-yes-0-fps
Copy link
Contributor

No description provided.

Copy link
Contributor

@Juniormunk Juniormunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some of my notes/questions. We should take care of them at some point. We don't need to do it in this PR; we need this.
Why are there different CameraInfoClasses and not just a camera type value?
We need to add some sort of password block to the new camera delete button.
The camera UUID is displayed in the UI when the camera is deleted. The camera UUID stuff seems a little half-baked.
There may be some sort of memory leak when deactivating cameras.
It seems like we might need better handling of no video modes and a video mode full of null?

@mcm001
Copy link
Contributor

mcm001 commented Jan 1, 2025

Risk posture is to just fail forwards and fix things in main. All good notes though, thanks for capturing them!

@mcm001 mcm001 merged commit 418eada into PhotonVision:main Jan 1, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants