-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix issue with escaped entities in RSS #10262
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement. Please check the test report below for more information |
So I made the code change to check for item, and I have a failure: " could not find app name slug in directory 'formpress'" I have -no- idea what that means in this case. |
Hi everyone, all test cases are passed! Ready for release! |
* Attempt to fix issue with escaped entities in RSS * Updated version numbers of dependent items * Updated a version again * Check for item existance, thx to @michelle0927 * update --------- Co-authored-by: michelle0927 <[email protected]>
WHAT
I ran into an issue where a workflow based on my RSS feed, https://www.raymondcamden.com/feed.xml, wasn't working correctly. The escape HTML entities in the title were being stripped out. I determined it came from the trigger. While looking at feedparser's github repo, I found that it was intentional, danmactough/node-feedparser#243, and that a workaround was to check for the meta values. My fix does this and overwrites the item.title ortiginally set. I did not test this as it was small, but, it was pretty minor.
copilot:summary
copilot:poem
WHY
I think I kinda covered it above.
HOW
copilot:walkthrough