Added support for the correct HTML5 elements and ARIA attributes #3
Conversation
|
Could you explain the advantage of these changes? Also, what is not correct according to HTML5 specs with the original code? |
|
The advantage is that people with certain disabilities can use the autocomplete if they are using for example a screenreader, the ARIA attributes indicate when there is something happening on the screen. And there isn't something with the current code but the datalist and option elements are more suitable for creating an autocomplete according to HTML5 specs, browsers that don't know these tags handle them as regulars divs. |
|
The autocompleter is supposed to be a tiny and efficient alternative to extensive, huge libraries such as jQuery UI. UI does things like that properly and I'm sure there are use cases where ARIA support is vital. However, in the way this plugin is typically used (e.g. suggestions for search input fields as seen on YouTube or Pixabay.com), it's merely there for a slightly improved user experience. It's sure great to have an ARIA supported fork version, but I'd suggest not to include it in the original version in favor of a smaller and more efficient code base. Thanks in any case! |
|
I understand the point you are coming from and I think it's great that this is completely Vanilla but I don't think the 1Kb difference in file size is that much of a bottleneck for someone who is looking for a good solution which offers everything you are looking for in an autocomplete. Please reconsider adding this support for people with disabilities since there isn't an out-of-the-box solution available so this is a great opportunity. These are small additions which make the autocomplete user experience accessible for people with a disability, and it's not only just for them but it also helps people who have to deal with a temporary disability like a broken arm who aren't able to use the mouse. |
|
It is a pity this branch was not merged :-/ |
No description provided.