Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify preCheck function #2224

Conversation

niuxiaojie81
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 464 lines in your changes are missing coverage. Please review.

Comparison is base (1569fd5) 54.93% compared to head (1796c12) 54.82%.
Report is 107 commits behind head on feature/bump-version-to-1.5.0.

Files Patch % Lines
eth/protocols/eth/handlers.go 0.00% 90 Missing ⚠️
core/snapshotdb/snapshotdb.go 10.93% 57 Missing ⚠️
p2p/server.go 8.47% 51 Missing and 3 partials ⚠️
core/vm/contracts.go 0.00% 33 Missing ⚠️
core/blockchain.go 25.64% 28 Missing and 1 partial ⚠️
core/parallel_executor.go 15.62% 21 Missing and 6 partials ⚠️
p2p/dial.go 46.80% 25 Missing ⚠️
consensus/cbft/cbft.go 17.24% 22 Missing and 2 partials ⚠️
eth/protocols/eth/peer.go 0.00% 20 Missing ⚠️
consensus/cbft/validator/validator.go 51.72% 13 Missing and 1 partial ⚠️
... and 28 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           feature/bump-version-to-1.5.0    #2224      +/-   ##
=================================================================
- Coverage                          54.93%   54.82%   -0.11%     
=================================================================
  Files                                595      595              
  Lines                             108552   108851     +299     
=================================================================
+ Hits                               59629    59680      +51     
- Misses                             44366    44596     +230     
- Partials                            4557     4575      +18     
Flag Coverage Δ
unittests 54.82% <21.22%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benbaley benbaley merged commit 4ee472d into PlatONnetwork:feature/bump-version-to-1.5.0 Dec 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants