Progsys remove is isnot #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Issue #150
The following pull request removes 'is'|'is not' from the grammars:
Checksum.bnf
Collatz Numbers.bnf
Compare String Lengths.bnf
Count Odds.bnf
Digits.bnf
Double Letters.bnf
Even Squares.bnf
For Loop Index.bnf
Grade.bnf
Last Index of Zero.bnf
Median.bnf
Mirror Image.bnf
Negative To Zero.bnf'
Pig Latin.bnf
Replace Space with Newline.bnf
Scrabble Score.bnf
Small Or Large.bnf
Smallest.bnf
String Differences.bnf
String Lengths Backwards.bnf
Sum of Squares.bnf
Super Anagrams.bnf'
Syllables.bnf
Wallis Pi.bnf
Word Stats.bnf
X-Word Lines.bnf
Context:
Issue #150
In the progsys problems 26 of the grammars contain:
<comp_op> ::= '<'|'>'|'=='|'>='|'<='|'!='|'is'|'is not'
Since python 3.8 the inclusion of 'is' and 'is not' in comparisons to literals is throwing a Warning.
Unless there is a good reason to retain them, we should consider removing the 'is'|'is not' as choices from the non-terminal <comp_op>
As jmmcd replied...
"Agreed. This <comp_op> is used only in ' '<comp_op>' ' and in this context there is no benefit to allowing is or is not."