Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of items flagged in dh community code review feedback #272

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

rlskoeser
Copy link
Contributor

@rlskoeser rlskoeser commented Nov 1, 2023

based on comments in DHCodeReview#2

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #272 (0a499bb) into develop (30c060b) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #272      +/-   ##
===========================================
- Coverage    15.97%   15.81%   -0.17%     
===========================================
  Files            9        9              
  Lines          751      746       -5     
  Branches       146      146              
===========================================
- Hits           120      118       -2     
+ Misses         547      544       -3     
  Partials        84       84              

@rlskoeser rlskoeser merged commit a3c34ad into develop Nov 1, 2023
@rlskoeser rlskoeser deleted the codereview-cleanup branch November 1, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant