-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable ONNX export #165
enable ONNX export #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @AlexanderPfefferle 🥳🥳 I also feel like it makes the code simpler, so that's great!
The pre-commit error is not related to this PR, I've just fixed it on main.
For the regressor test, IIRC, the change is because check_methods_subset_invariance
now also fail close to the 1e-7 threshold for lack of precision, correct?
Thinking about it, would it be easy to add a test that TabPFN is ONNX exportable, to make it sure it stays exportable? |
Yes exactly, |
Thanks a lot @AlexanderPfefferle ! onnx should be added to the dependencies (but not the main ones) to make the tests green. (I can also do it if you add me to your fork). |
I set the random state carefully to pass the regressor test for older versions, which is due to #175 and not to this pr. |
Merging, thanks a lot @AlexanderPfefferle ! |
modified the code to support ONNX export: