Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doc for inference config #79

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Improve doc for inference config #79

merged 2 commits into from
Jan 22, 2025

Conversation

LeoGrin
Copy link
Collaborator

@LeoGrin LeoGrin commented Jan 21, 2025

Change Description

Passing dictionaries should work with this new PR in the tabpfn package: PriorLabs/TabPFN#148

If you used new dependencies: Did you add them to requirements.txt?

Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.

Breaking changes

If you made any breaking changes, please update the version number.
Breaking changes are totally fine, we just need to make sure to keep the users informed and the server in sync.

Does this PR break the API? If so, what is the corresponding server commit?

Does this PR break the user interface? If so, why?


Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.

@LeoGrin LeoGrin requested a review from noahho January 21, 2025 18:12
Copy link
Collaborator

@noahho noahho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahho noahho merged commit a8aa2e6 into main Jan 22, 2025
5 checks passed
@noahho noahho deleted the improve_doc_for_config branch January 22, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants