Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OSD 3.x and 4.x #3635

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Allow OSD 3.x and 4.x #3635

merged 1 commit into from
Feb 8, 2023

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Feb 8, 2023

Fixes #3569

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Merging #3635 (17ba187) into master (aa4f5d6) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #3635   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         199      199           
  Lines        3422     3422           
=======================================
  Hits         3042     3042           
  Misses        380      380           
Impacted Files Coverage Δ
src/components/AccessTokenSender.js 100.00% <ø> (ø)
src/components/AnnotationSettings.js 100.00% <ø> (ø)
src/components/App.js 100.00% <ø> (ø)
src/components/AppProviders.js 91.30% <ø> (ø)
src/components/AttributionPanel.js 80.00% <ø> (ø)
src/components/AudioViewer.js 100.00% <ø> (ø)
src/components/BackgroundPluginArea.js 100.00% <ø> (ø)
src/components/Branding.js 100.00% <ø> (ø)
src/components/CanvasAnnotations.js 100.00% <ø> (ø)
src/components/CanvasInfo.js 100.00% <ø> (ø)
... and 106 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cbeer cbeer marked this pull request as ready for review February 8, 2023 16:34
@marlo-longley marlo-longley merged commit 44047ce into master Feb 8, 2023
@marlo-longley marlo-longley deleted the osd branch February 8, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump mirador to use openseadragon 3.0.0 or latest (bug of current osd render limited-bound image using max)
3 participants