fix:mirador_crash

[fstoe]

I found out that adding something through the add button in the catalog view which is json but not a manifest makes the viewer crash.
steps to reproduce:

• Open Mirador
• Add Resource with example url: https://iiif.io/api/presentation/2/context.json
• Open legit resource

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.59%. Comparing base (a8daa02) to head (5595b44).

Files with missing lines	Patch %	Lines
src/state/selectors/manifests.js	66.66%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3927   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files         315      315           
  Lines       14773    14776    +3     
  Branches     2491     2490    -1     
=======================================
+ Hits        13974    13977    +3     
  Misses        795      795           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lutzhelm]

Hi @fstoe, could you add a test case for that patch? createManifestoInstance itself is not exported, but getManifestoInstance calls it directly, so this would be a good place to add a test:

https://github.com/ProjectMirador/mirador/blob/master/__tests__/src/selectors/manifests.test.js#L56-L68

Something like

it('does not crash if json is not a manifest', () => {
  const state = { manifests: { x: { json: {} } } };
  const received = getManifestoInstance(state, { manifestId: 'x' });
  expect(received).toBe(undefined);
});

[fstoe]

Hey @lutzhelm,
thanks for the comment. I just added a small test case

Noticed another potential issue in the catalog

[lutzhelm]

I should have noticed this earlier: This change results in a list of errors in the catalog list for every manifest that is configured in the catalog settings but not in windows. While you can "Try again" successfully, this should be fixed. It's probably sufficient to change this line to

    error: manifest.error || (!manifesto && !!manifest.json),

Manifests that have not been used in windows before don't have a manifesto instance up until this point, and at the moment the component is initially rendered, isFetching is not yet true, so the same check that is used for ready should be used here additionally.

[lutzhelm]

I'm also thinking about how to test this automatically, no efficient idea yet, but I think it's not necessary for the scope of that PR.