Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use useId to generate unique ids for accessibility attributes. #4055

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Dec 17, 2024

No description provided.

@cbeer cbeer changed the title Use useId to generate unqiue ids for accessibility attributes. Use useId to generate unique ids for accessibility attributes. Dec 18, 2024
@cbeer cbeer force-pushed the a11y-ids branch 3 times, most recently from 1574bcb to c630588 Compare December 18, 2024 19:34
@cbeer cbeer marked this pull request as draft December 18, 2024 19:39
@cbeer cbeer force-pushed the a11y-ids branch 2 times, most recently from d8c8310 to 5e49588 Compare December 19, 2024 15:55
@cbeer cbeer marked this pull request as ready for review December 19, 2024 15:56
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.52%. Comparing base (05194d8) to head (c88eb43).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/components/CollectionInfo.js 71.42% 2 Missing ⚠️
src/components/WindowSideBarInfoPanel.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4055   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         313      313           
  Lines       14767    14773    +6     
  Branches     2496     2495    -1     
=======================================
+ Hits        13958    13964    +6     
  Misses        804      804           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marlo-longley marlo-longley merged commit f04609f into main Jan 8, 2025
9 checks passed
@marlo-longley marlo-longley deleted the a11y-ids branch January 8, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants