Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewritten documentation #31

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Rewritten documentation #31

merged 3 commits into from
Aug 25, 2020

Conversation

Saiv46
Copy link
Contributor

@Saiv46 Saiv46 commented Mar 10, 2020

  • Added protocol example
  • Added protodefc to README (add protodefc to readme #24)
  • Moved bool/cstring/void to primitive types
  • Added "lvarint" and "int" numeric types
  • Formatted schemas
  • Make protocol/type description more clear

* Added protocol example
* Moved bool/cstring/void to primitive type
* Added "lvarint" and "int" numeric types
* Formatted schemas
Copy link
Contributor

@roblabla roblabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I like the new organization. I disagree with adding lvarint though. varint has no notion of endianness in its encoding.

doc/datatypes/numeric.md Outdated Show resolved Hide resolved
Co-Authored-By: Robin Lambertz <[email protected]>
@Saiv46
Copy link
Contributor Author

Saiv46 commented Aug 25, 2020

@roblabla @rom1504 After 2 days I gonna close this PR and delete fork.

Copy link
Member

@rom1504 rom1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will remove lvarint after merge

@rom1504 rom1504 merged commit 6ab825b into ProtoDef-io:master Aug 25, 2020
extremeheat added a commit to extremeheat/node-protodef-validator that referenced this pull request Jun 10, 2021
rom1504 pushed a commit to ProtoDef-io/node-protodef-validator that referenced this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants