-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewritten documentation #31
Conversation
Saiv46
commented
Mar 10, 2020
- Added protocol example
- Added protodefc to README (add protodefc to readme #24)
- Moved bool/cstring/void to primitive types
- Added "lvarint" and "int" numeric types
- Formatted schemas
- Make protocol/type description more clear
* Added protocol example * Moved bool/cstring/void to primitive type * Added "lvarint" and "int" numeric types * Formatted schemas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I like the new organization. I disagree with adding lvarint
though. varint has no notion of endianness in its encoding.
Co-Authored-By: Robin Lambertz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will remove lvarint after merge
ProtoDef-io/ProtoDef#31 moved it from utils.json
ProtoDef-io/ProtoDef#31 moved it from utils.json