Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC-0003: Leo and Aleo instructions #15

Merged
merged 5 commits into from
Oct 4, 2022
Merged

ARC-0003: Leo and Aleo instructions #15

merged 5 commits into from
Oct 4, 2022

Conversation

collinc97
Copy link
Contributor

@collinc97 collinc97 commented Sep 30, 2022

Abstract

The purpose of this ARC is to unify syntax between Leo and Aleo instructions to make it clear what tools developers have at their disposal. We propose several breaking changes to both Leo and Aleo instructions to achieve this goal.

The discussion for this ARC is located at #17

@collinc97 collinc97 self-assigned this Sep 30, 2022
Copy link
Contributor

@bendyarm bendyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement on the syntax for both Leo and Aleo Instructions!
I think a 3-column table would be better, to better show how the syntax is being standardized.
How about this:

Leo V1 —> Leo V2 & Aleo Instructions V2 <— Aleo Instructions V1
--- program program
interface
mapping mapping mapping
circuit struct interface
record record record
@program function transition function
function function closure
name.network name.network name.network

@collinc97 collinc97 changed the title ARC-0003: Testnet 3.2 ARC-0003: Leo and Aleo Instructions Oct 3, 2022
@howardwu howardwu changed the title ARC-0003: Leo and Aleo Instructions ARC-0003: Leo and Aleo instructions Oct 3, 2022
@collinc97
Copy link
Contributor Author

This is an improvement on the syntax for both Leo and Aleo Instructions! I think a 3-column table would be better, to better show how the syntax is being standardized. How about this:

Leo V1 —> Leo V2 & Aleo Instructions V2 <— Aleo Instructions V1
--- program program
interface
mapping mapping mapping
circuit struct interface
record record record
@program function transition function
function function closure
name.network name.network name.network

This is a great idea Eric. Making the change now!

@evanmarshall
Copy link
Contributor

Hi, just a couple questions about the new interface.

  1. Can a program implement multiple interfaces?

  2. How will importing interfaces work? Is this planned to work with the Aleo Package Manager?

@howardwu
Copy link
Member

howardwu commented Oct 3, 2022

Hi, just a couple questions about the new interface.

  1. Can a program implement multiple interfaces?
  2. How will importing interfaces work? Is this planned to work with the Aleo Package Manager?

+1, I'm also still working through how to design interfaces, especially for Aleo instructions. Let's get this document merged and continue discussion on interfaces in the Discussion page.

@collinc97 collinc97 requested a review from bendyarm October 3, 2022 22:32
Copy link
Contributor

@bendyarm bendyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
If we want to get away from "breaking changes"
we could say something like "changes from the previous prerelease version" but that doesn't seem too important to me.

@collinc97
Copy link
Contributor Author

ARC-0003: Leo and Aleo instructions

Looks good to me! If we want to get away from "breaking changes" we could say something like "changes from the previous prerelease version" but that doesn't seem too important to me.

We can still iterate on the document once it is living.

@collinc97 collinc97 merged commit cc4909f into master Oct 4, 2022
@collinc97 collinc97 deleted the arc-0003 branch October 4, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants