Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hex and binary literals for integers. #28383

Merged
merged 1 commit into from
Oct 10, 2024
Merged

hex and binary literals for integers. #28383

merged 1 commit into from
Oct 10, 2024

Conversation

mikebenfield
Copy link
Collaborator

Note that they can't be used on the command line since SnarkVM does the parsing there.

@mikebenfield mikebenfield requested a review from d0cd October 5, 2024 08:29
@mikebenfield mikebenfield force-pushed the hex branch 3 times, most recently from 8b97172 to 7f94fbb Compare October 7, 2024 18:35
d0cd
d0cd requested changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions and nits. It would also be helpful to have some more failing tests, e.g 0xfieldfield, 0o98, -0x1u8

tests/tests/parser/statement/hex_int_fail.leo Show resolved Hide resolved
tests/tests/parser/program/hex_eof.leo Outdated Show resolved Hide resolved
errors/src/errors/parser/parser_errors.rs Show resolved Hide resolved
errors/src/errors/parser/parser_errors.rs Outdated Show resolved Hide resolved
compiler/parser/src/tokenizer/lexer.rs Show resolved Hide resolved
compiler/parser/src/tokenizer/lexer.rs Outdated Show resolved Hide resolved
compiler/ast/src/expressions/literal.rs Show resolved Hide resolved
@mikebenfield mikebenfield force-pushed the hex branch 2 times, most recently from 0d268c5 to 83bc56c Compare October 8, 2024 21:21
d0cd
d0cd approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikebenfield
hex, octal, and binary literals for integers.
3ae6b59 
Note that they can't be used on the command line since SnarkVM
does the parsing there.
@mikebenfield mikebenfield merged commit 5a0f39c into mainnet Oct 10, 2024
13 checks passed
@mikebenfield mikebenfield deleted the hex branch October 10, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d0cd d0cd d0cd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikebenfield @d0cd