Refactor inferred Future code for async functions. #28486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately many test expectation |
mikebenfield
force-pushed
the
new-future-inference
branch
from
e9fd76b to
9bab061
Compare
d0cd
reviewed
Jan 9, 2025
| @@ -0,0 +1,44 @@ | |||
| /* | |||
There was a problem hiding this comment.
Could we add another test where finalize1 and finalize2 both take a u8 as a parameter? We should expect that test to pass.
There was a problem hiding this comment.
That's already the test async_function_called_twice.leo
There was a problem hiding this comment.
The difference would be that there are two async functions in the child program.
d0cd
reviewed
Jan 9, 2025
d0cd
reviewed
Jan 9, 2025
d0cd
reviewed
Jan 9, 2025
d0cd
reviewed
Jan 9, 2025
d0cd
reviewed
Jan 9, 2025
d0cd
approved these changes
Jan 9, 2025
d0cd
reviewed
Jan 9, 2025
d0cd
reviewed
Jan 9, 2025
d0cd
reviewed
Jan 9, 2025
mikebenfield
force-pushed
the
new-future-inference
branch
2 times, most recently
from
3708b33 to
dae124c
Compare
Now it's possible to call the same async function from multiple async transitions.
mikebenfield
force-pushed
the
new-future-inference
branch
from
dae124c to
087e5f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's possible to call the same async function
from multiple async transitions.