Create SDK homepage with links to SDK tabs #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellewong793
changed the title
onetrickwolf
requested review from
christianwwwwwwww and
onetrickwolf
and removed request for
jaketarnow
There was a problem hiding this comment.
This looks great! I have some thoughts:
-
I think we should use "zero-knowledge" rather than "zero knowledge" just for consistency with the rest of the SDK and the website
-
Can we add a link to the Provable website on the link in the top right of the home page?
-
On the
/accountand other pages of the website, can we have the "Aleo SDK" link in the top left link back to the home page? -
For the buttons, the link is attached to the text itself, rather than the button so when you click on a button but don't click on the text it does nothing. I'd rather the whole button be a link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Create a new homepage for the SDK so user doesn't get immediately ported into the /account tab
Test Plan
Screenshot of mobile:
Screenshot of desktop:
