Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Update Develop Tab to include Create Account #917

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

michellewong793
Copy link
Collaborator

Motivation

Adds "Create Account: to the Develop tab so that user can create a new account before trying to deploy a program in the Develop tab

References to Monday here: https://provable.monday.com/boards/6731777034/views/146375343/pulses/7220947284

Test Plan

Screenshot:
screencapture-localhost-5173-develop-2024-08-19-14_23_59

Copy link
Collaborator

@christianwwwwwwww christianwwwwwwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@onetrickwolf onetrickwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I know this is to the spec of the ticket, but the execute program has an inline "generate random key" for people who wanted to just test a local execution real quick. Could do the same with deploy for people who just want to estimate fee without loading in a real account.

Can resolve in future tickets though.

@michellewong793 michellewong793 merged commit df5923b into testnet3 Aug 20, 2024
8 of 10 checks passed
@michellewong793 michellewong793 deleted the mwong/create-account-in-develop-tab branch August 20, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants