Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing JSON parsing to use bigint for all integers #925

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

Pauan
Copy link
Collaborator

@Pauan Pauan commented Sep 7, 2024

Fixes #892.

This is an alternate solution to #901

This parses all integers as a BigInt. We might want to be more selective, such as only parsing certain keys as BigInt.

Copy link
Collaborator

@jaketarnow jaketarnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaketarnow jaketarnow merged commit 0ec911f into ProvableHQ:testnet3 Sep 23, 2024
8 of 10 checks passed
@Pauan Pauan deleted the feat/bigint branch September 25, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Block data parsing loses precision and typing of bigInts
3 participants