Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an automatic node self-update feature #1703

Open
wants to merge 2 commits into
base: testnet2-2022
Choose a base branch
from

Conversation

ljedrz
Copy link
Collaborator

@ljedrz ljedrz commented Mar 24, 2022

This PR aims to replace the existing auto-update scripts by performing periodic checks on a specified branch of snarkOS, downloading any updates, rebuilding the node and restarting it with the same arguments as the ones it was started with. It also uses git and expects the host to be able to build snarkOS.

It is feature-gated and currently not enabled by default (but it probably should be once we decide to use it and update the docs) and - not unlike the scripts - only works on Unix-like systems. Btw, we might want to recommend that users use WSL by default due to our clang build requirement regardless.

Open points:

  • when should it become a default feature
  • what to do with the existing scripts
  • should the auto-update check interval be changed (I set it to 15 minutes)

@ljedrz ljedrz added the feature New feature or request label Mar 24, 2022
@ljedrz ljedrz requested review from howardwu and niklaslong March 24, 2022 11:08
@ljedrz ljedrz added linux Linux-specific issues macos labels Mar 24, 2022
niklaslong
niklaslong previously approved these changes Mar 24, 2022
@ljedrz
Copy link
Collaborator Author

ljedrz commented Mar 24, 2022

the clippy job failure is unrelated: briansmith/ring#1469

@ljedrz ljedrz mentioned this pull request Mar 28, 2022
@ljedrz ljedrz force-pushed the testnet3_auto_update branch from dc59061 to 496b995 Compare March 29, 2022 08:25
@ljedrz
Copy link
Collaborator Author

ljedrz commented Mar 29, 2022

Rebased.

@ljedrz ljedrz force-pushed the testnet3_auto_update branch from 496b995 to 4ae01b7 Compare April 26, 2022 10:33
@ljedrz ljedrz force-pushed the testnet3_auto_update branch 3 times, most recently from 5ac2905 to 8994c76 Compare May 5, 2022 09:55
@ljedrz ljedrz force-pushed the testnet3_auto_update branch from 8994c76 to 2ee65f6 Compare May 25, 2022 09:02
@ljedrz ljedrz force-pushed the testnet3_auto_update branch from 2ee65f6 to 3b0144e Compare June 28, 2022 08:45
@ljedrz
Copy link
Collaborator Author

ljedrz commented Jun 28, 2022

Rebased.

@aleo-svc-exp
Copy link

Admin: Please respond with "build this" in order to build this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request linux Linux-specific issues macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants