Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the dynamic MPF feature #33

Merged
merged 8 commits into from
Nov 21, 2024
Merged

Implementation of the dynamic MPF feature #33

merged 8 commits into from
Nov 21, 2024

Conversation

mrossinek
Copy link
Member

@mrossinek mrossinek commented Nov 15, 2024

This PR implements the dynamic MPF feature as proposed and demonstrated in 1 and 2.

Due to the ongoing migration of the docs from Github pages to https://docs.quantum.ibm.com/api/qiskit-addon-mpf, I chose to focus on API docs with proper code examples and will leave a tutorial and how-to guides to the future.

@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11955022700

Details

  • 550 of 550 (100.0%) changed or added relevant lines in 24 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11734664813: 0.0%
Covered Lines: 577
Relevant Lines: 577

💛 - Coveralls

@mrossinek
Copy link
Member Author

Some tests appear to be more flaky than expected. Will revisit this later this week in parallel to the documentation reviews of this PR

Co-authored-by: Kate Marshall <[email protected]>
Co-authored-by: Max Rossmannek <[email protected]>
Co-authored-by: Niall Robertson <[email protected]>
Co-authored-by: Alberto Baiardi <[email protected]>
Copy link

@kvcmarshall6 kvcmarshall6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mrossinek mrossinek merged commit 2bd6331 into main Nov 21, 2024
15 checks passed
@mrossinek mrossinek deleted the dynamic branch November 21, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants