-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python3.13 support and remove Python 3.8 support #2287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems sensible on the surface of it - I guess let's watch CI. This ought to come with a release note, since it's a public-facing change to Aer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor question. I think we should have a release note for this to comment that Aer now supports Python 3.13 - it's of interest to users.
When we're ready to merge, we can modify the branch-protection rules to allow merging with the new CI setup, since GitHub's still currently waiting for 3.8, 3.12.0, which don't run now.
cvxpy<1.5.0 | ||
cvxpy<1.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cvxpy 1.5.4 also doesn't have Python 3.13 wheels (though it's just a test dependency, not a build one). If 1.5.4 works, is there any chance that 1.6.0 works too, and we can just completely remove the upper bound?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reluctant to remove upper bounds in a project like Aer which is in maintenance mode, so the main pitfalls to handle are incompatible new version of libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that seems like a good idea for the dev requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Gadi
Summary
This PR adds Python 3.13 support for building wheels and removes Python 3.8 which was dropped by qiskit version 1.3.
Details and comments
The version of cibuildwheel was updated to the latest 2.22 to ensure support for Python 3.13.