fixes #2042 #2308
Open
fixes #2042 #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gadial
requested changes
Feb 9, 2025
| for creg in meas_circuit.cregs: | ||
| new_circ.add_register(creg) | ||
| if creg.name not in existing_creg_names: # Prevent duplicate registers | ||
| new_circ.add_register(creg) |
There was a problem hiding this comment.
This is not a good solution since we silently avoid adding some of the registers, leading to unexpected behavior for the user. We should either raise an error with clear description of the name clash or at least output a warning with the same description and rename the measurement register name (I prefer the first solution as I believe it lowers the chance for the user to create code with unexpected results).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
This is my first issue.
Summary
Fixed issue #2042 by adding a check for estimator adding duplicate classical registers in _combine_circs.
Details and comments
I added a check to _combinecircs in qiskit_aer > primitives > estimator.py to prevent a clash of register names for estimator which happens if the same name is used e.g. 'c'.