Apply changes for the files functionality #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tansito
commented
Jan 13, 2025
| @@ -14,7 +14,7 @@ authors = [] | |||
| dependencies = [ | |||
| "certifi>=2021.5.30", | |||
| "importlib_metadata>=4.8.1", | |||
| "qiskit_serverless>=0.18.0, <0.19.0", | |||
| "qiskit_serverless @ git+https://github.com/Qiskit/qiskit-serverless.git#subdirectory=client", | |||
There was a problem hiding this comment.
This change is just for the purpose of the PR to compare with our current development repository in serverless. It will need to be restore it before merge.
Tansito
commented
Jan 13, 2025
| @@ -37,7 +41,7 @@ setenv = | |||
| commands = | |||
| coverage3 run --source qiskit_ibm_catalog --parallel-mode -m pytest --doctest-modules | |||
| coverage3 combine | |||
| coverage3 report --fail-under=70 | |||
| coverage3 report --fail-under=50 | |||
There was a problem hiding this comment.
I needed to reduce the ratio coverage until we can dedicate resources to improve this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will apply the changes proposed in Qiskit/qiskit-serverless#1509 for the Files Management feature.