Skip to content

Commit

Permalink
Include visualization requirements in dev requirements (#2090)
Browse files Browse the repository at this point in the history
Co-authored-by: ptristan3 <[email protected]>
Co-authored-by: Kevin Tian <[email protected]>
  • Loading branch information
3 people authored Jan 7, 2025
1 parent 3f2ed4c commit 294c400
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 10 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -e '.[dev, visualization]'
pip install -e '.[dev]'
- name: Run black
run: make style
- name: Run lint
Expand All @@ -58,7 +58,7 @@ jobs:
pip install -U tox
pip install nbqa docutils
sudo apt install -y graphviz pandoc
pip install -e '.[dev, visualization]'
pip install -e '.[dev]'
wget https://github.com/errata-ai/vale/releases/download/v2.23.0/vale_2.23.0_Linux_64-bit.tar.gz
mkdir $HOME/bin && tar -xf vale_2.23.0_Linux_64-bit.tar.gz -C $HOME/bin
echo "$HOME/bin" >> $GITHUB_PATH
Expand Down Expand Up @@ -102,7 +102,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -e '.[dev, visualization]'
pip install -e '.[dev]'
- name: Run unit tests
run: make unit-test-coverage
- name: Report coverage to coveralls.io
Expand Down Expand Up @@ -145,7 +145,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -e '.[dev, visualization]'
pip install -e '.[dev]'
- name: Run integration tests
run: make integration-test
tests-finished:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests-qiskit-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -e '.[dev, visualization]' git+https://github.com/Qiskit/qiskit.git
pip install -e '.[dev]' git+https://github.com/Qiskit/qiskit.git
- name: Run integration tests
run: make integration-test
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -e '.[dev, visualization]'
pip install -e '.[dev]'
- name: Run integration tests
run: make integration-test
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests-terra-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
python -m pip install --upgrade pip
# Installing the complete environment should happen in one `pip install` step,
# or pip will generally allow broken combinations of packages to be installed.
pip install -e '.[dev, visualization]' git+https://github.com/Qiskit/qiskit.git
pip install -e '.[dev]' git+https://github.com/Qiskit/qiskit.git
- name: Run tests
# running unit tests against latest (non-released) code of qiskit-terra gives a basic level
# of confidence that the integration between qiskit-ibm-runtime and qiskit-terra works
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,5 @@ visualization = ["plotly>=5.23.0"]
dev = [
"qiskit-ibm-runtime[common]",
"qiskit-ibm-runtime[documentation]",
"qiskit-ibm-runtime[visualization]",
]


2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ commands =
[testenv:docs]
envdir = .tox/docs
deps =
-e .[dev, visualization]
-e .[dev]
commands =
python tools/concat_release_notes.py
sphinx-build -j auto -W -b html {posargs} {toxinidir}/docs {toxinidir}/docs/_build/html
Expand Down

0 comments on commit 294c400

Please sign in to comment.