Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway / scheduler refactor protptype #1082

Closed
wants to merge 9 commits into from

Conversation

akihikokuroda
Copy link
Collaborator

@akihikokuroda akihikokuroda commented Nov 10, 2023

Summary

Prototype for #1033

Details and comments

This is on top of PR #1077. The changes for this prototype are in the last commit.

The changes are:

  1. wrap the entry point sent to Ray. it sends a notification to the gateway when the entry point completes execution. It eliminates the polling of the ray job status.
  2. put a signal listener for Job db changes. It can check if a Job to be scheduled and it some resources to be cleaned up.

@akihikokuroda akihikokuroda marked this pull request as draft November 10, 2023 17:11
@akihikokuroda
Copy link
Collaborator Author

This is a quick prototype. There are a lot of things to clean up. Please take look. Thanks!

@IceKhan13
Copy link
Member

IceKhan13 commented Nov 10, 2023

ok, I think we need to have some kind of development branch to merge dependent PRs there. Otherwise we have bunch of PRs that sits in queue and we develop over them, while we should develop independently

@akihikokuroda
Copy link
Collaborator Author

I can make this independent (based on the current main). It can show better what are changes.

@psschwei
Copy link
Collaborator

I can make this independent (based on the current main).

big +1 for this 😄

@akihikokuroda
Copy link
Collaborator Author

PR is recreated based on current main branch in #1084. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants