Files list end point refactor #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korgan00
requested changes
Nov 7, 2024
korgan00
reviewed
Nov 7, 2024
|
Thank you so much @korgan00 , as soon as I return from vacations I will take a look 🙏 |
korgan00
requested changes
Nov 20, 2024
|
Apart from the comment from enum I think I addressed all your comments, @korgan00 . Thank you so much for the review, definitely it got quite better the PR. |
korgan00
requested changes
Nov 20, 2024
|
I closed the conversation around the enum assuming is fine for you, @korgan00 👍 |
korgan00
approved these changes
Nov 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of an effort to stabilize
filesAPI end-points in #1509This PR focuses on
files/andfiles/provider/end-points to be able to list the files in the working directories for the user and for the provider.Details and comments
files/end-point was separated in two:files/now contains the paths:username/andusername/provider/functionwith the purpose to separated files from functions from the user's root folderfiles/provider/to manage the pathprovider/functionso now each function will have its own folder in the provider directory.FileStoragewas created to manage the logic of access to this storage for providers and users with the purpose to simplify the view.