Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oxidize BasisTranslator]: Move the rest of the BasisTranslator to Rust. #13237

Merged
merged 12 commits into from
Oct 31, 2024
Merged

[Oxidize BasisTranslator]: Move the rest of the BasisTranslator to Rust. #13237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3c00fdd
Initial: Move the rest of the `BasisTranslator` to Rust.
raynelfss Sep 27, 2024
3f00a73
Fix: Redundancies with serialization methods
raynelfss Oct 8, 2024
81bdec4
Refactor: Remove `BasisTranslator` struct, use pymethod.
raynelfss Oct 9, 2024
71f2e1d
Lint: Ignore too_many_args flag from clippy on `basis_translator::run()`
raynelfss Oct 9, 2024
82d22f1
Merge branch 'main' into oxidize-basis-translator
raynelfss Oct 9, 2024
709d706
Fix: Remove redundant clone
raynelfss Oct 10, 2024
679f4c8
Merge branch 'main' into oxidize-basis-translator
raynelfss Oct 21, 2024
c9040ff
Fix: Leverage using `unwrap_operation` when taking op_nodes from the …
raynelfss Oct 21, 2024
f8c9c87
Update crates/accelerate/src/basis/basis_translator/mod.rs
raynelfss Oct 29, 2024
1618900
Merge branch 'main' into oxidize-basis-translator
raynelfss Oct 29, 2024
e369460
Adapt to #13164
raynelfss Oct 29, 2024
444b400
Merge branch 'main' into oxidize-basis-translator
raynelfss Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions crates/accelerate/src/basis/basis_translator/basis_search.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
use std::cell::RefCell;

use hashbrown::{HashMap, HashSet};
use pyo3::prelude::*;

use crate::equivalence::{EdgeData, Equivalence, EquivalenceLibrary, Key, NodeData};
use qiskit_circuit::operations::Operation;
Expand All @@ -23,28 +22,6 @@ use rustworkx_core::traversal::{dijkstra_search, DijkstraEvent};

use super::compose_transforms::{BasisTransformIn, GateIdentifier};

/// Search for a set of transformations from source_basis to target_basis.
/// Args:
/// equiv_lib (EquivalenceLibrary): Source of valid translations
/// source_basis (Set[Tuple[gate_name: str, gate_num_qubits: int]]): Starting basis.
/// target_basis (Set[gate_name: str]): Target basis.
///
/// Returns:
/// Optional[List[Tuple[gate, equiv_params, equiv_circuit]]]: List of (gate,
/// equiv_params, equiv_circuit) tuples tuples which, if applied in order
/// will map from source_basis to target_basis. Returns None if no path
/// was found.
#[pyfunction]
#[pyo3(name = "basis_search")]
pub(crate) fn py_basis_search(
py: Python,
equiv_lib: &mut EquivalenceLibrary,
source_basis: HashSet<GateIdentifier>,
target_basis: HashSet<String>,
) -> PyObject {
basis_search(equiv_lib, &source_basis, &target_basis).into_py(py)
}

type BasisTransforms = Vec<(GateIdentifier, BasisTransformIn)>;
/// Search for a set of transformations from source_basis to target_basis.
///
Expand Down
10 changes: 0 additions & 10 deletions crates/accelerate/src/basis/basis_translator/compose_transforms.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,6 @@ pub type GateIdentifier = (String, u32);
pub type BasisTransformIn = (SmallVec<[Param; 3]>, CircuitFromPython);
pub type BasisTransformOut = (SmallVec<[Param; 3]>, DAGCircuit);

#[pyfunction(name = "compose_transforms")]
pub(super) fn py_compose_transforms(
py: Python,
basis_transforms: Vec<(GateIdentifier, BasisTransformIn)>,
source_basis: HashSet<GateIdentifier>,
source_dag: &DAGCircuit,
) -> PyResult<HashMap<GateIdentifier, BasisTransformOut>> {
compose_transforms(py, &basis_transforms, &source_basis, source_dag)
}

pub(super) fn compose_transforms<'a>(
py: Python,
basis_transforms: &'a [(GateIdentifier, BasisTransformIn)],
Expand Down
Loading