Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test of a synthesis with a customized gate for TwoQubitControlledUDecomposer #13433

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add a test of a synthesis with a customized gate for TwoQubitControlledUDecomposer #13433

merged 1 commit into from
Nov 14, 2024

Conversation

ShellyGarion
Copy link
Member

Summary

Following #13139, this PR adds another test with a customized RXX-equivalent gate (namely, H(0) RZZ(0,1) H(1)) for TwoQubitControlledUDecomposer

Thanks @alexanderivrii for his help!

Details and comments

@ShellyGarion ShellyGarion added the Changelog: None Do not include in changelog label Nov 13, 2024
@ShellyGarion ShellyGarion requested review from alexanderivrii and a team as code owners November 13, 2024 15:30
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11820492896

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.005%) to 88.927%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 92.2%
crates/qasm2/src/lex.rs 2 92.98%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 11816528045: -0.005%
Covered Lines: 79331
Relevant Lines: 89209
💛 - Coveralls

Cryoris
Cryoris approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@ShellyGarion ShellyGarion added this pull request to the merge queue Nov 14, 2024
Merged via the queue into Qiskit:main with commit 41c0306 Nov 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryoris Cryoris Cryoris approved these changes

@mtreinish mtreinish Awaiting requested review from mtreinish

@alexanderivrii alexanderivrii Awaiting requested review from alexanderivrii alexanderivrii is a code owner

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShellyGarion @qiskit-bot @coveralls @Cryoris