This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
add qiskit basis passes #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
reviewed
Jun 29, 2022
|
|
||
| def run_qiskit_basis(benchmark, basis_method, basis, path): | ||
| circuit = QuantumCircuit.from_qasm_file(str(path)) | ||
| pm = _qiskit_pass_manager(basis_method, basis) |
There was a problem hiding this comment.
Instead of doing this maybe we can leverage generate_translation_passmanager() https://github.com/Qiskit/qiskit-terra/blob/0.21.0rc1/qiskit/transpiler/preset_passmanagers/common.py#L226 which will mirror what transpile() uses internally.
There was a problem hiding this comment.
This seems to do several passes so you don't get the same granularity but I'm ok with this division at this stage.
mtreinish
pushed a commit
that referenced
this pull request
Aug 10, 2022
* Initial commit: Added CI Job to test new benchmarks * Added test file (copy of run_bv.py) * Added Matthew's suggestions (#4) * Initial commit for ci tests * Change bash script * Bash script does not need cat * Added second test file to test * Sugar is unnecessary * Added test in mapping * Mapping takes way longer. Will develop further. * Delete tests.txt Deleted old residuals, ready to merge with ci branch * Added upload artifact action (#6) * Another test for CI * Organized CI actions. * Added both the text file and the original results as artifacts * Added more aesthetic changes suggested by Matthew (#9) * Added more changes suggested by Matthew * Added proper management of __init__.py files (#11) * Another test for CI * Organized CI actions. * Added both the text file and the original results as artifacts * Added more changes suggested by matthew * Added method to handle changes to __init__.py files * Fixed error in main.yml file * Fixing another error in yaml file * Fixing scope error in yaml * Updated changed-files 24 -> 24.1 * Attempt 1 * Attempt 2 * Attempt 3 * Worked. Fixed typo... Now reordering. * Made a change in init file, let's see if it detects * Fixed bash code * Checking for something suspicious * Checking for something suspicious * Fixing something suspicious * Fixed? * Fixed?? * Test with only __init__ file * Final commit before merging * Improved Runtime by removing Washington, Brooklyn and Rochester backends. (#13) * Remove usage of Washington, Brooklyn and Rockester backends due to slow runtime. * What if there are no changes? * Handle no files in a healthy way * No changes works! Going back to adding changes. * Created custom action to test each specific benchmark (#15) * Try customized action * Added custom acrtion to workflow. * Fixed typo in workflow. * Modified action location * Modified action location 2 * Modified action location 3 * Modified action location 4 * Fixed path for testing * Fixed typo in line 22 of action. * Housekeeping, and red-added exclusions. * Final commit, custom action is ready to be merged. * Final fixes before merging (#17) * Final fixes before merging * Added modifications to CONTRIBUTING.md * Added last modification to CONTRIBUTING.md * Delete test.py for final version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for qiskit basis passes. Currently it just uses circuits from
benchmarks/miscwhich may not involve much translation.