This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Quantum Volume #31
Open
Yelissal
wants to merge
33
commits into
Qiskit:main
Choose a base branch
from
Yelissal:QuantumVolume
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Quantum Volume #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generated qasm files for all qv ranging from 4 to 2^10. - Work in progress
- Linted: __init__.py and run_qv.py
- It takes 30-40 minutes, though. - Prints max quantum volume. - Needs to be refined to be more pytest-y
…into QuantumVolume
mtreinish
reviewed
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename the q_volume
file to q_volume.py
right now python/pytest (and github) won't treat it as a Python file without the .py file extension. Additionally I think you might have been working from a dirty branch it looks like there is a copy of the QPE benchmark in this branch too.
@mtreinish That file was more of a draft me and Ray used to refine the code. I'll remove it. The actual benchmark is the run_qv file. |
Other functions will be added later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with @raynelfss @danielleodigie on Quantum Volume benchmark.