Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass database as argument for Postgres schema command #241

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pass database as argument for Postgres schema command #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion replibyte/src/source/postgres.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ impl<'a> Explain for Postgres<'a> {
let dump_args = vec![
"-s", // dump only the schema definitions
"--no-owner",
"-d",
self.database,
"-h",
self.host,
"-p",
Expand Down Expand Up @@ -123,6 +125,8 @@ impl<'a> Source for Postgres<'a> {
"--no-owner", // skip restoration of object ownership
"-h",
self.host,
"-d",
self.database,
"-p",
s_port.as_str(),
"-U",
Expand All @@ -138,7 +142,6 @@ impl<'a> Source for Postgres<'a> {

dump_args.append(&mut only_tables_args);

dump_args.push(self.database);

// TODO: as for mysql we can exclude tables directly here so we can remove the skip_tables_map checks
let mut process = Command::new("pg_dump")
Expand Down