-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed propensity example #70
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 15 15
Lines 1544 1544
=======================================
Hits 1465 1465
Misses 79 79 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet - thanks!
"metadata": {}, | ||
"source": [ | ||
"```{note}\n", | ||
"This is not true for this dataset but we use it for illustration purposes.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I got the point but it might be worth replacing the pronoun 'this' with the subject you are referring to reduce the likelihood of a misunderstanding. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Kevin Klein <[email protected]>
Co-authored-by: Kevin Klein <[email protected]>
Co-authored-by: Kevin Klein <[email protected]>
Co-authored-by: Kevin Klein <[email protected]>
Co-authored-by: Kevin Klein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Would using The |
Absolutely - great point! |
As explained in #54 we want to support some method of passing "fixed" propensity scores. This PR does not change any in the implementation but rather shows how one can do it with the existing implementation creating a custom model.
Rendered version
Checklist
CHANGELOG.rst
entry