Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/port control #231

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Feature/port control #231

merged 2 commits into from
Apr 8, 2024

Conversation

QuantumEntangledAndy
Copy link
Owner

This adds a sub command to adjust the ports and availability of various services that the CAMERA provides. This dosen't effect what neolink provides

Note: This will not work on the cameras that do not have these features like E1 and Argus2E

# To turn on http
neolink services --config=config.toml CameraName http on
# Or off
neolink services --config=config.toml CameraName http off
# Or set the port
neolink services --config=config.toml CameraName http port 80
# Or get the current port details
neolink services --config=config.toml CameraName http get

Services are

  • http
  • https
  • rtmp
  • rtsp
  • onvif (will also turn on rtsp)

For example rtsp

neolink services --config=config.toml CameraName rtsp on

Fixes #225

Copy link

@daurnimator daurnimator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked!

$ ./target/debug/neolink --config neolink.toml services Doorbell http on
[2024-04-07T22:57:39Z INFO  neolink] Neolink v0.6.3.rc.1-33-g54f7665 debug
[2024-04-07T22:57:39Z INFO  neolink::utils] Doorbell: Connecting to camera at Address: 10.1.1.12
[2024-04-07T22:57:39Z INFO  neolink_core::bc_protocol] Doorbell: Trying TCP discovery
[2024-04-07T22:57:39Z INFO  neolink_core::bc_protocol] Doorbell: TCP Discovery success at 10.1.1.12:9000
[2024-04-07T22:57:39Z INFO  neolink::utils] Doorbell: Logging in
[2024-04-07T22:57:39Z INFO  neolink::utils] Doorbell: Connected and logged in
[2024-04-07T22:57:41Z INFO  neolink::common::camthread] Doorbell: Camera time is already set: 2024-04-08 8:57:41.0 -10:00:00
[2024-04-07T22:57:43Z INFO  neolink::common::neocam] Doorbell: Model Reolink Video Doorbell PoE
[2024-04-07T22:57:43Z INFO  neolink::common::neocam] Doorbell: Firmware Version v3.0.0.2676_23090702

And now the doorbell is listening on port 80 as expected.

@QuantumEntangledAndy QuantumEntangledAndy merged commit d354b90 into master Apr 8, 2024
32 checks passed
@QuantumEntangledAndy QuantumEntangledAndy deleted the feature/port_control branch April 8, 2024 03:47
@QuantumEntangledAndy
Copy link
Owner Author

Ok then merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subcommand to modify port settings
2 participants