Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic test: Check whether false positives with allocated occur on CI #467

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Jan 22, 2025

Diagnostic Test PR to check whether false positives with allocated occur on CI

Motivation: A lot of false positives on CI with allocated that causes many tests on CI to fail. This PR aims to check whether that is the case.

Expected behavior:

apply! mul_left! canonicalize!: Test Failed at /home/runner/work/QuantumClifford.jl/QuantumClifford.jl/test/test_allocations.jl:27
  Expression: allocated(f4) < 1500n
   Evaluated: 48368 < 3000

Stacktrace:
 [1] macro expansion
   @ ~/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/Test/src/Test.jl:679 [inlined]
 [2] macro expansion
   @ ~/work/QuantumClifford.jl/QuantumClifford.jl/test/test_allocations.jl:27 [inlined]
 [3] macro expansion
   @ ~/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/Test/src/Test.jl:1704 [inlined]
 [4] top-level scope
   @ ~/work/QuantumClifford.jl/QuantumClifford.jl/test/test_allocations.jl:6
  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them.

@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Jan 22, 2025

@Krastanov, the diagnostic test seems to have verified the hypothesis. There is indeed errors on CI due to false positives with allocated in test_allocations.jl. The issue has been reported: JuliaLang/julia#57064

Thank you for your insights into this matter. This issue happened here 15/20 hours earlier here on CI.

apply! mul_left! canonicalize!: Test Failed at /Users/runner/work/QuantumClifford.jl/QuantumClifford.jl/test/test_allocations.jl:24
  Expression: allocated(f3) < 1500n
   Evaluated: 19980032 < 1500

Stacktrace:
 [1] macro expansion
   @ ~/hostedtoolcache/julia/1.11.3/aarch64/share/julia/stdlib/v1.11/Test/src/Test.jl:679 [inlined]
 [2] macro expansion
   @ ~/work/QuantumClifford.jl/QuantumClifford.jl/test/test_allocations.jl:24 [inlined]
 [3] macro expansion
   @ ~/hostedtoolcache/julia/1.11.3/aarch64/share/julia/stdlib/v1.11/Test/src/Test.jl:1704 [inlined]
 [4] top-level scope
   @ ~/work/QuantumClifford.jl/QuantumClifford.jl/test/test_allocations.jl:6

Edit:

I thought PR demonstration of CI errors would be best way to report these errors instead of opening Bug Report 🙏🏼 I first encountered these errors in a earlier PR #466 this morning. 🙏🏼 I look forward to your insights about these errors due to allocated!

Please feel free to close the PR, as its purpose was to highlight the CI errors and potential causes behind them.

@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Jan 28, 2025

Closing this PR as the purpose of PR was achieved. Link of error: https://github.com/QuantumSavory/QuantumClifford.jl/actions/runs/12909614253/job/35997712920?pr=467#step:6:1006

@Fe-r-oz Fe-r-oz closed this Jan 28, 2025
@Fe-r-oz Fe-r-oz deleted the fa/false-positives-with-allocated branch January 28, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant