Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move delayedProts out of the loop #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move delayedProts out of the loop #176

wants to merge 1 commit into from

Conversation

hanakl
Copy link
Contributor

@hanakl hanakl commented Jan 16, 2025

This PR resolves method definition warnings that were cause by a test in this PR . The issue was that a resumable function (delayedProts) was defined inside a loop, which has now been fixed.

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.09%. Comparing base (b1c8f5e) to head (3c50b2d).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   68.09%   68.09%           
=======================================
  Files          42       42           
  Lines        1730     1730           
=======================================
  Hits         1178     1178           
  Misses        552      552

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

Benchmark Result

Judge result

Benchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jl

Job Properties

  • Time of benchmarks:
  • Target: 16 Jan 2025 - 05:31
  • Baseline: 16 Jan 2025 - 05:32
  • Package commits:
  • Target: 4434f8
  • Baseline: b1c8f5
  • Julia commits:
  • Target: 4976d0
  • Baseline: 4976d0
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["tagquery", "register", "queryall"] 0.97 (5%) 0.92 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["register", "creation_and_initialization"]
  • ["tagquery", "messagebuffer"]
  • ["tagquery", "misc"]
  • ["tagquery", "register"]

Julia versioninfo

Target

Julia Version 1.10.7
Commit 4976d05258e (2024-11-26 15:57 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.1 LTS
 uname: Linux 6.8.0-1017-azure #20-Ubuntu SMP Tue Oct 22 03:43:13 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3223 MHz 3954 s 0 s 289 s 2999 s 0 s
 #2 3239 MHz 4169 s 0 s 273 s 2780 s 0 s
 #3 3245 MHz 3973 s 0 s 314 s 2958 s 0 s
 #4 3245 MHz 4315 s 0 s 274 s 2603 s 0 s
 Memory: 15.615276336669922 GB (13605.8984375 MB free)
 Uptime: 730.46 sec
 Load Avg: 1.29 2.6 1.73
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.7
Commit 4976d05258e (2024-11-26 15:57 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.1 LTS
 uname: Linux 6.8.0-1017-azure #20-Ubuntu SMP Tue Oct 22 03:43:13 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3279 MHz 4056 s 0 s 298 s 3516 s 0 s
 #2 3245 MHz 4520 s 0 s 294 s 3036 s 0 s
 #3 3248 MHz 4035 s 0 s 322 s 3517 s 0 s
 #4 3244 MHz 4404 s 0 s 284 s 3131 s 0 s
 Memory: 15.615276336669922 GB (13578.8046875 MB free)
 Uptime: 793.31 sec
 Load Avg: 1.1 2.29 1.68
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jl

Job Properties

  • Time of benchmark: 16 Jan 2025 - 5:31
  • Package commit: 4434f8
  • Julia commit: 4976d0
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["register", "creation_and_initialization", "from_tests"] 210.481 μs (5%) 983.23 KiB (1%) 2552
["tagquery", "messagebuffer", "query"] 298.185 ns (5%) 64 bytes (1%) 2
["tagquery", "messagebuffer", "querydelete"] 2.133 μs (5%) 96 bytes (1%) 3
["tagquery", "misc", "from_tests"] 10.981 μs (5%) 26.44 KiB (1%) 233
["tagquery", "register", "query"] 3.606 s (5%) 2.063 s 482.69 MiB (1%) 4585623
["tagquery", "register", "queryall"] 3.340 s (5%) 2.076 s 1.20 GiB (1%) 3424121

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["register", "creation_and_initialization"]
  • ["tagquery", "messagebuffer"]
  • ["tagquery", "misc"]
  • ["tagquery", "register"]

Julia versioninfo

Julia Version 1.10.7
Commit 4976d05258e (2024-11-26 15:57 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.1 LTS
 uname: Linux 6.8.0-1017-azure #20-Ubuntu SMP Tue Oct 22 03:43:13 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3223 MHz 3954 s 0 s 289 s 2999 s 0 s
 #2 3239 MHz 4169 s 0 s 273 s 2780 s 0 s
 #3 3245 MHz 3973 s 0 s 314 s 2958 s 0 s
 #4 3245 MHz 4315 s 0 s 274 s 2603 s 0 s
 Memory: 15.615276336669922 GB (13605.8984375 MB free)
 Uptime: 730.46 sec
 Load Avg: 1.29 2.6 1.73
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jl

Job Properties

  • Time of benchmark: 16 Jan 2025 - 5:32
  • Package commit: b1c8f5
  • Julia commit: 4976d0
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["register", "creation_and_initialization", "from_tests"] 217.585 μs (5%) 983.23 KiB (1%) 2552
["tagquery", "messagebuffer", "query"] 303.585 ns (5%) 64 bytes (1%) 2
["tagquery", "messagebuffer", "querydelete"] 2.134 μs (5%) 96 bytes (1%) 3
["tagquery", "misc", "from_tests"] 10.680 μs (5%) 26.44 KiB (1%) 233
["tagquery", "register", "query"] 3.560 s (5%) 2.014 s 482.69 MiB (1%) 4585623
["tagquery", "register", "queryall"] 3.431 s (5%) 2.125 s 1.30 GiB (1%) 3694121

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["register", "creation_and_initialization"]
  • ["tagquery", "messagebuffer"]
  • ["tagquery", "misc"]
  • ["tagquery", "register"]

Julia versioninfo

Julia Version 1.10.7
Commit 4976d05258e (2024-11-26 15:57 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.1 LTS
 uname: Linux 6.8.0-1017-azure #20-Ubuntu SMP Tue Oct 22 03:43:13 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3279 MHz 4056 s 0 s 298 s 3516 s 0 s
 #2 3245 MHz 4520 s 0 s 294 s 3036 s 0 s
 #3 3248 MHz 4035 s 0 s 322 s 3517 s 0 s
 #4 3244 MHz 4404 s 0 s 284 s 3131 s 0 s
 Memory: 15.615276336669922 GB (13578.8046875 MB free)
 Uptime: 793.31 sec
 Load Avg: 1.1 2.29 1.68
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 4
On-line CPU(s) list: 0-3
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7763 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4890.86
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves user_shstk clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 1 MiB (2 instances)
L3 cache: 32 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Vulnerable: Safe RET, no microcode
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@Krastanov
Copy link
Member

LGTM if test failures are unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanakl @Krastanov