node-can-bridge: Add support for Linux and macOS #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on M3 Pro Apple Silicon (aarch64)
Manifest workflows, just to get checks of building and releases at least created.
Manifest GitHub Actions workflows
Points to the correct repository now instead of the upstream repository
Added proper support for macOS, Linux, ARM64, and ARM32 based systems. Rewrote handling artifacts from unzipping, to moving artifacts to correct directories based on what platforms are downloaded and what is currently running on. Added documentation to helper functions.
New platforms are able to link and build. Tested on macOS.
Enabling exceptions for the compiler causes the project to build without issues, as the compiler would not like having no exception support similar to how macOS operates.
Might need more work but at least it doesn't error
On Windows builds, there was an issue with dependencies not copying and therefore not linking when building native modules, this is now fixed.
Removed duplicated builds and renamed builds of CANBridge.
The stopHeartbeats function was removed in a previous commit, which caused MSVC builds to break. This commit re-adds the function to fix the build. The function will need to be reimplemented with the current codebase, as of right now this does nothing.
Fixes failure on macOS after this was changed elsewhere
Updated compile instructions and formatting.
EXCEPTIONS GO BRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRR it's 3am and i need sleep i spent way too long on this stupid bug but thats how code goes anyways good night
This was referenced Jul 2, 2024
|
Other notes to be made, we have added CI to this to validate not only the already existing workflows, but also new builds to support Linux and macOS. |
NoahAndrews
requested changes
Jul 2, 2024
There was a problem hiding this comment.
Thank you for contributing, and seeking feedback early on!
I've left a few comments, but I haven't done a deep dive on this. REVrobotics/CANBridge#29 should probably receive most of your attention for now.
Bump node-gyp-build to version 4.8.0 and node-gyp to version 10.1.0 in package.json.
Removal of `setuptools` install step due to bumped `node-gyp` version.
On commit b0ca096, there were many unintended changes made to this file. This reverts those changes.
ci: Remove `setuptools` step
# Conflicts: # package-lock.json # package.json
It just made it harder to get the actual error and actual stack trace.
Revert changes made to `canWrapper.cc`
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @unofficial-rev-port team has been hard at work making the core technologies used by the REV Hardware Client work on all 3 major platforms (Windows, macOS, Linux). This PR contains changes needed for node-can-bridge to compile and run on macOS and Linux in addition to Windows, including the changes to pull the OS-specific binaries from CANBridge (see REVrobotics/CANBridge#29).
Please note that this PR is still a work-in-progress; while we have successfully ran a local build of the REV Hardware Client that was able to load and initialize the CAN backend, we are still in the process of testing with real hardware to ensure full functionality (and no regressions) on all 3 OSes. We are opening this PR in the current state in order to gather feedback and make sure we do the changes in a way acceptable to having the PR merged upstream (once completed, of course).