Optionally log more stats #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**WIP**
There are some additional stats that could be tracked:
```
averagerating
ratingcount
trendingdaily
trendingmonthly
trendingweekly
weightedRating
```
This is a POC of how it could be done. It defaults to the existing stats. If you uncomment lines 22-23, it will then also track `trendingweekly` & `trendingdaily`.
If there is an existing ``` `${extensionName}-stats-${isoDateString}.csv` ``` file with matching CSV headers, it will write to it. If the headers are wrong, it will append a number to end, incrementing this number as needed: ``` `${extensionName}-stats-${isoDateString}_${suffix++}.csv` ```
Some of the changes (the most glaring being the switch from `require` to `import`) are due to the use of a top-level `await`.
---
While throwing this together, I ran across a bug introduced in RandomFractals#5 -- the CSV headers were only changed from `DateTime, Installs, Downloads, Version` to `DateTime, Installs, Updates, Downloads, Version` in the `console.log`, they should've also been changed on [line 65](https://github.com/RandomFractals/vscode-marketplace-ext-stats/blob/0224c96/tools/vscode-marketplace-stats.js#L65) where they are written to the `.csv` file (as well as in a few comments).
**WIP** Needed for top-level `await` in `tools/vscode-marketplace-stats.js` Line 5: `"type": "module",` does the magic. See https://www.google.com/search?q=top+level+await+type+module+package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some additional stats being returned that could be logged:
This is a POC of how it could be done. It defaults to logging the existing stats. If you uncomment lines 22-23, it will then also track
trendingweekly&trendingdaily.If there is an existing
`${extensionName}-stats-${isoDateString}.csv`file with matching CSV headers, it will write to it. If the headers are wrong, it will append a number to the end, incrementing this number as needed:`${extensionName}-stats-${isoDateString}_${suffix++}.csv`Some of the changes (the most glaring being the switch from
requiretoimport) are due to the use of a top-levelawait.I added a
package.json(npm init -y, then changedlicenseandauthor), again to support the use of a top-levelawait.Line 5:
"type": "module",does the magic. See https://www.google.com/search?q=top+level+await+type+module+package.json