Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session storing and sharing #420

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

Session storing and sharing #420

wants to merge 40 commits into from

Conversation

bvdmitri
Copy link
Member

@bvdmitri bvdmitri commented Feb 4, 2025

This PR implements session history in RxInfer with the ability to share it if user wants that. Includes 2 new documentation sections on how it works and what data does it collects. Telemetry is off by default. Lets discuss it during our next update meeting

Some remaining work include:

Add more contextual information to the :inference invoke

  • @autoupdates
  • @initialization
  • returnvars
  • predictvars
  • addons
  • options
  • historyvars
  • keep_history
  • used callbacks
  • allow_node_contraction
  • Anonymous form for delete shared data request

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 49.22601% with 164 lines in your changes missing coverage. Please review.

Project coverage is 78.50%. Comparing base (1f8a562) to head (2e5e61a).

Files with missing lines Patch % Lines
src/telemetry.jl 3.96% 121 Missing ⚠️
src/session.jl 71.55% 33 Missing ⚠️
src/inference/inference.jl 86.30% 10 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1f8a562) and HEAD (2e5e61a). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (1f8a562) HEAD (2e5e61a)
5 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   84.70%   78.50%   -6.20%     
==========================================
  Files          19       22       +3     
  Lines        1523     1838     +315     
==========================================
+ Hits         1290     1443     +153     
- Misses        233      395     +162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant