Add WP-CLI task to add srcset to all images #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses DOMDocument to find images, then pulls the image ID from the `wp-image-*` class (could switch to whatever content filtering is used for ResponsiveImagesCG#144, so we’re not reliant on something that might be disabled). Generate the srcset, add it to the image tag, and update the post.
ryelle
changed the title
|
@ryelle this looks awesome. What are the downsides to |
joemcgill
force-pushed
the
dev
branch
2 times, most recently
from
51ce34b to
8b9bf7e
Compare
|
+1 Why don't you merge this? |
|
Now that we've switched to using a display filter (#177) to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-pass PR for #143
Add
wp respimg add-srcset, to check all posts (and pages, all public CPTs but attachments) for image tags and if the image does not already have asrcsetattribute, add the srcset. This first saves a revision of the old post, makes the change, then updates the post with the srcset'd images.I'm not sure
DOMDocumentis a great approach for replacing the image, so if something better is decided in #144, we can switch to that.This is really beta, and could use a lot of testing/feedback.