feat: build ui for similar game suggestions #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
reviewed
Jan 16, 2025
...tures/game-list/components/SimilarGameSuggestionsMainRoot/SimilarGameSuggestionsMainRoot.tsx
Outdated
Show resolved
Hide resolved
| </div> | ||
| </div> | ||
|
|
||
| <GameSuggestionsDataTable /> |
There was a problem hiding this comment.
Not sure how easy it would be to remove the relatedGame icon from every row, as it's implied by the page header.
There was a problem hiding this comment.
Took some creativity, but should be updated in latest:
The only wording I'm not so confident in is the similar beaten/mastered verbiage, ie: "Also mastered by same players". Maybe it actually sounds okay and it only sounds weird to me because I've been reciting it in my head over and over.
There was a problem hiding this comment.
I think it's okay. Maybe it might be less weird if you got rid of the Also?
There was a problem hiding this comment.
Yeah, with a fresh set of eyes, removing "also" from those two phrases sounds better. Done in latest.
Jamiras
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the migration of the game suggestions pages to React by building out the UI for
/game/{game}/suggestions.This page is functionally equivalent with the one introduced in #3045, with the exception of a new buttonlink that takes the user to their personalized suggestions page (
/games/suggestions):