Create Sysbolic link for Windows #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robitx
reviewed
Jul 29, 2024
lua/gp/init.lua
Outdated
Comment on lines
1671
to
1672
| file_name = file_name:gsub("\\", "/") | ||
| chat_dir = chat_dir:gsub("\\", "/") |
There was a problem hiding this comment.
Thanks for the fix. Could you give me an example of why is this needed here? Wouldn't it be sufficient to put it in the if file_name ~= last and vim.fn.has("win32") then branch?
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbolic links cannot be created using the
lncommand in Windows.I will use New-Item in PowerShell to create a symbolic link.
This will solve #176 issue.