-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-307 Implement Fabric platform support #376
Conversation
Temporary draft status, but I am not sure if there is still a need to add or modify content |
Hey @huanmeng-qwq nice to see another PR grom you. |
Also I have problem with this issue: #349 I think we can resolve this as in the minestom platform (one full string argument represents all arguments) |
It does look good, let me give it a try. Also, it seems that Fabric does not support directly introducing sub projects as mod dependencies, which has led to the failure of CI |
The reason why the problem only occurs on jdk17 is because the project requires 17 to run, so it was ignored in jdk8 |
Ah okay, you are right |
It seems that my writing style is incorrect. I obtained the correct way through reporting issues |
It should be possible now |
Don't worry, I will review your code :P |
examples/fabric/src/main/java/dev/rollczi/example/fabric/ExampleFabric.java
Outdated
Show resolved
Hide resolved
litecommands-fabric/src/main/java/dev/rollczi/litecommands/fabric/FabricCommand.java
Outdated
Show resolved
Hide resolved
...s-fabric/src/main/java/dev/rollczi/litecommands/fabric/tools/FabricOnlyPlayerContextual.java
Outdated
Show resolved
Hide resolved
litecommands-fabric/src/main/java/dev/rollczi/litecommands/fabric/FabricCommand.java
Outdated
Show resolved
Hide resolved
litecommands-fabric/src/main/java/dev/rollczi/litecommands/fabric/LiteFabricFactory.java
Outdated
Show resolved
Hide resolved
litecommands-fabric/src/main/java/dev/rollczi/litecommands/fabric/LiteFabricFactory.java
Outdated
Show resolved
Hide resolved
…leFabric.java Co-authored-by: Norbert Dejlich <[email protected]>
Co-authored-by: Norbert Dejlich <[email protected]>
litecommands-fabric/src/main/java/dev/rollczi/litecommands/fabric/FabricPlatform.java
Outdated
Show resolved
Hide resolved
litecommands-fabric/src/main/java/dev/rollczi/litecommands/fabric/FabricPlatform.java
Outdated
Show resolved
Hide resolved
…ric/FabricPlatform.java
…ric/FabricPlatform.java
require assets/litecommands/icon.png |
ModMenu supports you to view the icons of installed mods in the game |
|
Yes you arę right. But I compared |
|
thanks <3 |
@huanmeng-qwq I added a few changes. Please check if they suit you and everything is okay. |
Okay, it can be merged |
Thank you again ❤️ |
Looks awesome, can't wait to test. |
@creatorfromhell You can checkout new snapshot maven("https://repo.eternalcode.pl/snapshots") |
Cheers. The project I need it for I still have to port over from the previous lib I used xD |
Closes #307