Merge pull request #153 from RyanClementsHax/vitest

Vitest

.github/workflows/ci.yml

@@ -15,6 +15,10 @@ jobs:
           node-version: 22
       - name: restore dependencies
         uses: bahmutov/npm-install@v1
+      - name: restore dependencies
+        uses: bahmutov/npm-install@v1
+        with:
+          working-directory: e2e
       - run: npm run lint:all
   type_check:
     name: type check
@@ -39,8 +43,11 @@ jobs:
       - name: restore dependencies
         uses: bahmutov/npm-install@v1
       - run: npm run test
+      - name: report coverage
+        if: always()
+        uses: davelosert/vitest-coverage-report-action@v2
   e2e:
-    timeout-minutes: 60
+    timeout-minutes: 15
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4

.prettierignore

@@ -1,5 +1,4 @@
 node_modules
-yarn.lock
 lib
 dist
 coverage

.stylelintignore

@@ -1,6 +1,4 @@
 node_modules
-yarn.lock
 lib
-dist
 examples
 coverage

.vscode/extensions.json

@@ -7,6 +7,7 @@
     "stylelint.vscode-stylelint",
     "bradlc.vscode-tailwindcss",
     "csstools.postcss",
-    "ms-playwright.playwright"
+    "ms-playwright.playwright",
+    "vitest.explorer"
   ]
 }

.vscode/settings.json

@@ -9,7 +9,8 @@
   "scss.validate": false,
   "editor.codeActionsOnSave": {
     "source.fixAll.markdownlint": "explicit",
-    "source.fixAll.stylelint": "explicit"
+    "source.fixAll.stylelint": "explicit",
+    "source.fixAll.eslint": "explicit"
   },
   "stylelint.validate": ["css", "scss", "postcss"]
 }

e2e/test_repos/drivers/create-react-app.ts

@@ -113,7 +113,6 @@ async function startServerWithRetry({
   while (attemptNumber <= maxAttempts) {
     attemptNumber++
     if (attemptNumber > 1) {
-      // eslint-disable-next-line no-console
       console.log(
         `Retrying (attempt ${attemptNumber}) starting the server because: ${failedReason}`
       )

e2e/test_repos/drivers/index.ts

@@ -157,7 +157,7 @@ class IsolatedRepoInstanceImpl implements IsolatedRepoInstance {
         })
       }, 20_000)
       serveProcess.stderr.pipe(process.stderr)
-      serveProcess.stdout.on('data', chunk => {
+      serveProcess.stdout.on('data', (chunk: { toString(): string }) => {
         if (finishedMonitoring) return
         const newChunk = chunk.toString()
         stdout += newChunk
@@ -187,7 +187,9 @@ class IsolatedRepoInstanceImpl implements IsolatedRepoInstance {
         } catch (e: unknown) {
           clearTimeout(failTimeout)
           finishedMonitoring = true
-          void stop().then(() => reject(e))
+          void stop().then(() =>
+            reject(e instanceof Error ? e : new Error(JSON.stringify(e)))
+          )
         }
       })
     })

e2e/test_repos/test.ts

@@ -80,7 +80,7 @@ class TestRepoBuilderImpl implements TestRepoBuilder {
 
   async open(): Promise<{ repo: TestRepo; root: ThemeRoot }> {
     if (!this.#themerConfig) {
-      throw new Error('cannot open without first defining the themer config')
+      throw new Error('Cannot open without first defining the themer config')
     }
 
     const { url, stop: _stop } = await openWithConfig({
@@ -187,6 +187,8 @@ class ThemeRootImpl implements ThemeRoot {
     const attributesInputLocator = this.#attributesInputLocator
     return {
       async get(): Promise<Record<string, string>> {
+        // We'll pinky promise here 🤞
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-return
         return JSON.parse(await attributesInputLocator.inputValue())
       },
       async patch(updates: Record<string, string>): Promise<void> {

eslint.config.mjs

@@ -0,0 +1,66 @@
+import eslint from '@eslint/js'
+import tseslint from 'typescript-eslint'
+import vitest from 'eslint-plugin-vitest'
+import playwright from 'eslint-plugin-playwright'
+
+export default tseslint.config(
+  {
+    ignores: [
+      'lib',
+      'examples',
+      'coverage',
+      'e2e/test_repos/templates',
+      '**/test-results',
+      '**/playwright-report'
+    ]
+  },
+  eslint.configs.recommended,
+  ...tseslint.configs.recommendedTypeChecked,
+  {
+    languageOptions: {
+      parserOptions: {
+        projectService: true
+      }
+    },
+    rules: {
+      quotes: ['warn', 'single'],
+      'no-unused-vars': 'off',
+      '@typescript-eslint/no-unused-vars': [
+        'warn',
+        { varsIgnorePattern: '^_', ignoreRestSiblings: true }
+      ],
+      '@typescript-eslint/no-floating-promises': 'error'
+    }
+  },
+  {
+    ignores: ['e2e/**'],
+    languageOptions: {
+      parserOptions: {
+        project: './tsconfig.json'
+      }
+    },
+    rules: {
+      '@typescript-eslint/unbound-method': 'off',
+      '@typescript-eslint/no-unsafe-assignment': 'off',
+      '@typescript-eslint/no-unsafe-return': 'off',
+      '@typescript-eslint/no-unsafe-call': 'off',
+      '@typescript-eslint/no-unsafe-argument': 'off'
+    }
+  },
+  {
+    files: ['e2e/**/*.?(c|m)[jt]s?(x)'],
+    languageOptions: {
+      parserOptions: {
+        project: './e2e/tsconfig.json'
+      }
+    }
+  },
+  {
+    files: ['src/**/*.{test,spec}.?(c|m)[jt]s?(x)'],
+    ...vitest.configs.recommended
+  },
+  {
+    ...playwright.configs['flat/recommended'],
+    files: ['e2e/tests/**']
+  }
+)