This repository has been archived by the owner on Feb 3, 2020. It is now read-only.
arm support #27
Open
arm support #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitalych
reviewed
Jan 4, 2020
| @@ -106,17 +106,21 @@ int VM::setTSSAddress(uint64_t tss_addr) { | |||
| } | |||
|
|
|||
| int VM::setUserMemoryRegion(kvm_userspace_memory_region *region) { | |||
| m_cpu->requestExit(); | |||
| if (m_cpu) { | |||
There was a problem hiding this comment.
The commit message looks broken
There was a problem hiding this comment.
This commit should go into a separate PR.
vitalych
reviewed
Jan 4, 2020
CMakeLists.txt
Outdated
| @@ -78,7 +78,7 @@ find_package(LIBCOROUTINE REQUIRED) | |||
| message(STATUS "Found libcoroutine ${LIBCOROUTINE_PACKAGE_VERSION}") | |||
|
|
|||
| if(WITH_TARGET MATCHES "s2e") | |||
| # TODO: look at libcpu compile options to figure this out | |||
| # TODO: look at libcpu compile options to figure this out§ | |||
vitalych
reviewed
Jan 4, 2020
| libs2e.cpp | ||
| s2e-kvm-io.cpp | ||
| s2e-kvm-state-arm.cpp | ||
| s2e-kvm-trace.cpp |
There was a problem hiding this comment.
This commit should not be here. Please squash your previous changes.
vitalych
reviewed
Jan 4, 2020
src/s2e-kvm-vcpu.cpp
Outdated
| } | ||
| #endif | ||
| else if (m_cpuBuffer->ready_for_interrupt_injection) { | ||
| } else if (m_cpuBuffer->ready_for_interrupt_injection) { |
There was a problem hiding this comment.
This commit should be squashed.
vitalych
reviewed
Jan 4, 2020
| @@ -287,7 +287,8 @@ void S2EKVM::initLogLevel(void) { | |||
|
|
|||
| const char *libcpu_log_file = getenv("LIBCPU_LOG_FILE"); | |||
| if (libcpu_log_file) { | |||
| logfile = fopen(libcpu_log_file, "w"); | |||
| //logfile = fopen(libcpu_log_file, "w"); | |||
| logfile = freopen(libcpu_log_file, "w", stdout); | |||
There was a problem hiding this comment.
Not sure about this. Maybe you used it for debugging and forgot to remove?
weizhou-chaojixx
force-pushed
the
arm-support
branch
from
a1106da to
d33a194
Compare
Signed-off-by wei zhou <[email protected]>
Signed-off-by: chaojixx <[email protected]>
Signed-off-by: chaojixx <[email protected]>
…m env If cpu exit due to sregs updated, the env->kvm_exit_code will be set as 1. When sregs have been synced the kvm_exit_code will be reset to 0. Signed-off-by: wei zhou <[email protected]>
Signed-off-by: chaojixx <[email protected]>
Signed-off-by: chaojixx <[email protected]>
weizhou-chaojixx
force-pushed
the
arm-support
branch
from
d33a194 to
2cc280d
Compare
allow user to custom the memory regions Signed-off-by: chaojixx <[email protected]>
This tells the client that the KVM is able to custom the memory regions Signed-off-by: chaojixx <[email protected]>
Signed-off-by: chaojixx <[email protected]>
weizhou-chaojixx
force-pushed
the
arm-support
branch
from
db8477c to
5d9dfa0
Compare
Signed-off-by: weizhou-chaojixx <[email protected]>
Signed-off-by: weizhou-chaojixx <[email protected]>
Signed-off-by: weizhou-chaojixx <[email protected]>
Signed-off-by: weizhou-chaojixx <[email protected]>
Signed-off-by: weizhou-chaojixx <[email protected]>
Signed-off-by: weizhou-chaojixx <[email protected]>
Signed-off-by: weizhou-chaojixx <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.