Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added csp report json file generation #429

Open
wants to merge 4 commits into
base: v2
Choose a base branch
from
Open

Conversation

shahzeb79
Copy link

@matz3 as discussed before in a meeting, i would like to propose a change directly to middleware than writing my own middleware or changing karma settings. It will generate a json file in current folder which can be later consumed as needed.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 93.293% when pulling a79a863 on shahzeb79:patch-1 into e0dd20e on SAP:master.

@RandomByte
Copy link
Member

Hi Shahzeb, Thank you for this suggestion. However, I guess there are some other things we need to put in place for it to work in your scenario. The MiddlewareManager needs to expose the configuration option of the CSP middleware so that karma-ui5 (and UI5 CLI) can expose it as well. On that note, we'd probably opt for an option that also allows to define the file path.

Since you are only interested in the final report, we should also add a debouncing. Limiting file updates to only take place if no new data has arrived for ~one second.

And of course we also need to add unit tests for this feature.

We'll track this internally as CPOUI5FOUNDATION-436. Please reach out to Andreas in case this is of high priority for you.

@RandomByte RandomByte changed the base branch from master to v2 November 3, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants