scst.h, scst, device handlers: Fix scst_replace_port_info #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scst_pass_through_cmd_done
can run in interrupt context, and callscst_replace_port_info
, which in turn was callingscst_lookup_tg_id
. Sincescst_lookup_tg_id
does amutex_lock
, we should not call it from interrupt context.The call path was added in e72eae3 and could lead to:
(BTW, the fix suggested in this PR was influenced by the current location of
scst_pass_through_cmd_done
&scst_lookup_tg_id
.)