Allowed namespace injection without managed #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jain-naman-sf
requested review from
davidmreed and
jkasturi-sf
and removed request for
kdvenkata,
davidmreed and
jkasturi-sf
|
Hey @jkasturi-sf Please review this PR |
jstvz
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Thanks for your work here. I noticed two things we need to check:
- Your changes look at the task options (managed and namespace) to decide about the namespace filter. But, the work item and discussion in task run_tests not including namespace in query #3089 suggests we should look at the details of the target org instead (e.g.
self.org_config.namespace). - You don't have any tests that confirm the new behavior as specified in the acceptance criteria on the story.
So, we need the task to look at the target org's details to choose if the namespace filter is used, not just the task options.
Can you adjust this? Let me know if you need more information or if anything is unclear.
…ooling/CumulusCI into bug/run-tests=not-infer-namespace
|
Hey @jstvz I have added the functionality to infer namespace from target org directly along with tests. |
jstvz
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.