Upgrade to Await::promise() API #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jun 9, 2022
ghost
reviewed
Jun 9, 2022
ghost
suggested changes
Jun 14, 2022
Co-authored-by: 커피와 우유 <[email protected]>
|
why vscode make unverified commit |
ghost
reviewed
Jun 14, 2022
| @@ -56,7 +56,7 @@ dev/rwlock.phar: Makefile | |||
| touch $@ | |||
|
|
|||
| dev/await-generator.phar: Makefile | |||
| wget -O $@ https://poggit.pmmp.io/v.dl/SOF3/await-generator/await-generator/^3.1.0 | |||
| wget -O $@ https://poggit.pmmp.io/v.dl/SOF3/await-generator/await-generator/^3.4.1 | |||
There was a problem hiding this comment.
need update 3.4.2??
just comment change in 3.4.2
Seems to be a GitHub issue. I'll squash this branch when I am home. |
Commit signature is a cryptography thing. It has nothing to do with what IDE you use. |
|
Error: Unable to reserve cache with key php-build-generic-8.0.11-[object Promise], another job may be creating this cache. hmmmm |
|
Yes, that's a known issue, I will fix it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.